Eth Address cleanup #387

mrLSD · 2021-12-08T14:23:33Z

For more strict types related to Eth address we need modifications:

modify Address type to own type
Cleanup current EthAddress type with new Address type
Implement Borsh Ser/Deserializer for Address type.

joshuajbouw

I would double check to ensure that anything that is stored anywhere is the exact same format as it currently is. That and ensure that any external call args can certainly be parsed.

engine-types/src/lib.rs

engine-types/src/parameters.rs

engine/src/connector.rs

…o feat/eth-addrass-cleanup

birchmd

Looks pretty good! Most of my comments are minor.

engine-types/src/types/address.rs

engine/src/parameters.rs

engine/src/transaction/eip_1559.rs

engine/src/transaction/mod.rs

Co-authored-by: Michael Birch <birchmd8@gmail.com>

…aurora-engine into feat/eth-addrass-cleanup

birchmd

Nice work!
I left a couple more comments, but looks good to me over all.

engine-types/src/types/address.rs

engine/src/engine.rs

Co-authored-by: Michael Birch <birchmd8@gmail.com>

joshuajbouw

Looks good now :D

* Feat(standalone): Add debug tracing of remaining gas values (#391) * Balance type refactoring (#386) * Remove standalone binary (#403) * Eth Address cleanup (#387) * Fix(dep) Pass std feature on to rjson library (#402) * Feat(benchmarks): update gas bounds after wasm cost reduction (#406) * Feat(tests): Mock touching trie nodes (#408) * Fix: Only allow owner to call deploy_upgrade (#410) * Feat(tests): Uniswap multi-hop swap benchmark (#415) * Fix(engine): Return revert error message during contract deploy (#424) * Move engine transactions module to engine-transactions crate (#418) * Avoid using wasmer directly (#420) * Fix compilation after #418 merge * Use default git attributes for Cargo.lock (#421) * Switch to rebranded blake2 (#422) * Remove unused unused (#423) * Chore: make aurora compatible with latest nightlies (#425) * Chore: upgrade to the recent nightly (#426) * chore: upgrade to the latest nearcore version (#427) * chore: move to 2021 edition (#428) * Benchmark contract performing only pure arithmetic and memory operations (#429) * Fix(engine): Require chain_id (#432) * chore: make sure aurora is using the latest cost config (#435) * Fix(test): make uniswap benchmarks reproducible (#437) * Fix(test): lower gas limit on OOG test; this is needed because the solidity compiler got more efficient, not because of a regression in EVM gas metering correctness * Fix(engine): Cache generation values to avoid repeated state reads (#438) * Fix(engine): Optimize is_account_empty (#439) * Fix(test): update uniswap wasm fraction; this is needed because optimizations from #438 and #439 together lowered the fraction of gas spent on IO * Fix(engine): Upgrade to latest SputnikVM (#445) * Fix(engine): Simple cache to stop consecutive duplicate reads (#446) * Version update and change log Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>

* Feat(standalone): Add debug tracing of remaining gas values (#391) * Balance type refactoring (#386) * Remove standalone binary (#403) * Eth Address cleanup (#387) * Fix(dep) Pass std feature on to rjson library (#402) * Feat(benchmarks): update gas bounds after wasm cost reduction (#406) * Feat(tests): Mock touching trie nodes (#408) * Fix: Only allow owner to call deploy_upgrade (#410) * Feat(tests): Uniswap multi-hop swap benchmark (#415) * Fix(engine): Return revert error message during contract deploy (#424) * Move engine transactions module to engine-transactions crate (#418) * Avoid using wasmer directly (#420) * Fix compilation after #418 merge * Use default git attributes for Cargo.lock (#421) * Switch to rebranded blake2 (#422) * Remove unused unused (#423) * Chore: make aurora compatible with latest nightlies (#425) * Chore: upgrade to the recent nightly (#426) * chore: upgrade to the latest nearcore version (#427) * chore: move to 2021 edition (#428) * Benchmark contract performing only pure arithmetic and memory operations (#429) * Fix(engine): Require chain_id (#432) * chore: make sure aurora is using the latest cost config (#435) * Fix(test): make uniswap benchmarks reproducible (#437) * Fix(test): lower gas limit on OOG test; this is needed because the solidity compiler got more efficient, not because of a regression in EVM gas metering correctness * Fix(engine): Cache generation values to avoid repeated state reads (#438) * Fix(engine): Optimize is_account_empty (#439) * Fix(test): update uniswap wasm fraction; this is needed because optimizations from #438 and #439 together lowered the fraction of gas spent on IO * Fix(engine): Upgrade to latest SputnikVM (#445) * Fix(engine): Simple cache to stop consecutive duplicate reads (#446) * Version update and change log Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.5.0. (#460) * Engine: Upgrade to latest SputnikVM changes (#455) * Engine: further caching optimizations (#456) * Use EthTransactionKind reference to serialize into bytes (#457) * Test: Reproduce GdASJ3KESs8VegpFECTveCwLQp8fxw8yvsauNEmGb6pZ gas failure (#454) * Fix typo: promise_create (#452) * Fix(Engine): Transactions to the zero address are not the same as transactions with empty to field (#458) Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.5.1. (#470) * Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462) * Implement a NEAR native version of the Solidity pure arithmetic benchmark to compare EVM execution cost with direct wasm cost (#463) * Fix features related to panic_info_message (#466) * Fix(standalone): set predecessor_account_id appropriately when executing promise callbacks (#467) * Fix(engine): fix bug in checking if an address exists (#469) * Version update * Update unreleased link Co-authored-by: Joshua J. Bouw <joshua.j.bouw@aurora.dev> Release 2.5.2. (#475) * Revert "Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462)" Release 2.5.3. (#527) * Fix(precompile): ExitToNear ExitToEthereum vulnerability patch Fix vulnerability Include exploit contract * Release 2.5.3 notes * Update solidity version Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.6.0. (#494) * Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462) * Fix(precompiles): Allow native precompiles to work in the standalone engine (#473) * Standalone engine improvements (#478) * Fix(Engine): Predecessor id precompile works in view calls (#477) * Feat(standalone): Persist transaction data (#481) * Feat(Engine): Add custom precompile for NEAR prepaid_gas (#479) * Test: Reproduce 8ru7VEAEbyfZdbC1W2PYQv2cY3W92rbTToDEN4yTp8aZ gas failure (#485) * Feat(standalone): Function to get latest/earliest block (#482) * Engine optimization: cache all reads from NEAR state (#488) * Feat(standalone): Handle call to new method of Engine contract (#490) * Feat(engine-types): optional serde integration (#468) * Changed near-blake2 dependency (#484) * Feat(standalone): thread-safety and serde (#496) * Refactor repro tests to have less boilerplate (#497) * Add serde for TraceTransaction (#495) * Fix(standalone): include possible execution errors in the TransactionIncludedOutcome result field (#500) * Reproduce transaction FRcorNvFojoxBrdiVMTy9gRD3H8EYXXKau4feevMZmFV (#498) * Reproduce transaction 5bEgfRQ5TSJfN9XCqYkMr9cgBLToM7JmS1bNzKpDXJhT (#499) * Fix(connector): Return an error when storage cannot be read instead of panicking (#501) * Standalone: forward underlying rocksdb crate features (#502) * Feat(tests): Multisender benchmark (#503) * Feat(test): Reproduce D98vwmi44hAYs8KtX5aLne1zEkj3MUss42e5SkG2a4SC (#504) * Standalone engine storage saves the AccountId of the associated engine deployed on chain (#510) * Fix(precompiles): Fix secp256k1 run not returning empty slice on an incorrect V byte (#513) * Self-contained wasm contract for testing 5bEgfRQ (#514) * Update gas estimation code to use new data from NEAR protocol v53 (#517) * Fix: Legacy transactions must be allowed (#520) * Chore(precompiles): Include blake2 compression only (#528) * Build(deps): Upgrade `libsecp256k1` version 0.3.5 => 0.7.0 (#515) * Bump regex from 1.5.4 to 1.5.6 (#526) * Bump regex from 1.5.4 to 1.5.6 in /etc/ft-receiver (#525) * Bump zeroize_derive from 1.1.0 to 1.3.2 (#523) * Bump crossbeam-deque from 0.8.0 to 0.8.1 (#521) * Bump crossbeam-utils from 0.8.4 to 0.8.8 (#524) * Bump cross-fetch from 2.2.3 to 2.2.6 in /etc/eth-contracts (#508) * Bump simple-get from 2.8.1 to 2.8.2 in /etc/eth-contracts (#507) * Bump follow-redirects from 1.14.0 to 1.15.1 in /etc/eth-contracts (#529) * Bump shelljs from 0.8.4 to 0.8.5 in /etc/eth-contracts * Fix(ecrecover): Set malleability flag to `0` for ecrecover. (#474) Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Roman Hodulák <roman.hodulak@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Release 2.6.1. (#537) * Fix: Don't allow fee stealing. * Fix: Don't allow bridge receipt forging. * Fix(engine): Correctly account for changes in total supply of ETH on Aurora (#536) Co-authored-by: Michael Birch <michael.birch@aurora.dev>

* Feat(standalone): Add debug tracing of remaining gas values (#391) * Balance type refactoring (#386) * Remove standalone binary (#403) * Eth Address cleanup (#387) * Fix(dep) Pass std feature on to rjson library (#402) * Feat(benchmarks): update gas bounds after wasm cost reduction (#406) * Feat(tests): Mock touching trie nodes (#408) * Fix: Only allow owner to call deploy_upgrade (#410) * Feat(tests): Uniswap multi-hop swap benchmark (#415) * Fix(engine): Return revert error message during contract deploy (#424) * Move engine transactions module to engine-transactions crate (#418) * Avoid using wasmer directly (#420) * Fix compilation after #418 merge * Use default git attributes for Cargo.lock (#421) * Switch to rebranded blake2 (#422) * Remove unused unused (#423) * Chore: make aurora compatible with latest nightlies (#425) * Chore: upgrade to the recent nightly (#426) * chore: upgrade to the latest nearcore version (#427) * chore: move to 2021 edition (#428) * Benchmark contract performing only pure arithmetic and memory operations (#429) * Fix(engine): Require chain_id (#432) * chore: make sure aurora is using the latest cost config (#435) * Fix(test): make uniswap benchmarks reproducible (#437) * Fix(test): lower gas limit on OOG test; this is needed because the solidity compiler got more efficient, not because of a regression in EVM gas metering correctness * Fix(engine): Cache generation values to avoid repeated state reads (#438) * Fix(engine): Optimize is_account_empty (#439) * Fix(test): update uniswap wasm fraction; this is needed because optimizations from #438 and #439 together lowered the fraction of gas spent on IO * Fix(engine): Upgrade to latest SputnikVM (#445) * Fix(engine): Simple cache to stop consecutive duplicate reads (#446) * Version update and change log Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.5.0. (#460) * Engine: Upgrade to latest SputnikVM changes (#455) * Engine: further caching optimizations (#456) * Use EthTransactionKind reference to serialize into bytes (#457) * Test: Reproduce GdASJ3KESs8VegpFECTveCwLQp8fxw8yvsauNEmGb6pZ gas failure (#454) * Fix typo: promise_create (#452) * Fix(Engine): Transactions to the zero address are not the same as transactions with empty to field (#458) Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.5.1. (#470) * Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462) * Implement a NEAR native version of the Solidity pure arithmetic benchmark to compare EVM execution cost with direct wasm cost (#463) * Fix features related to panic_info_message (#466) * Fix(standalone): set predecessor_account_id appropriately when executing promise callbacks (#467) * Fix(engine): fix bug in checking if an address exists (#469) * Version update * Update unreleased link Co-authored-by: Joshua J. Bouw <joshua.j.bouw@aurora.dev> Release 2.5.2. (#475) * Revert "Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462)" Release 2.5.3. (#527) * Fix(precompile): ExitToNear ExitToEthereum vulnerability patch Fix vulnerability Include exploit contract * Release 2.5.3 notes * Update solidity version Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.6.0. (#494) * Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462) * Fix(precompiles): Allow native precompiles to work in the standalone engine (#473) * Standalone engine improvements (#478) * Fix(Engine): Predecessor id precompile works in view calls (#477) * Feat(standalone): Persist transaction data (#481) * Feat(Engine): Add custom precompile for NEAR prepaid_gas (#479) * Test: Reproduce 8ru7VEAEbyfZdbC1W2PYQv2cY3W92rbTToDEN4yTp8aZ gas failure (#485) * Feat(standalone): Function to get latest/earliest block (#482) * Engine optimization: cache all reads from NEAR state (#488) * Feat(standalone): Handle call to new method of Engine contract (#490) * Feat(engine-types): optional serde integration (#468) * Changed near-blake2 dependency (#484) * Feat(standalone): thread-safety and serde (#496) * Refactor repro tests to have less boilerplate (#497) * Add serde for TraceTransaction (#495) * Fix(standalone): include possible execution errors in the TransactionIncludedOutcome result field (#500) * Reproduce transaction FRcorNvFojoxBrdiVMTy9gRD3H8EYXXKau4feevMZmFV (#498) * Reproduce transaction 5bEgfRQ5TSJfN9XCqYkMr9cgBLToM7JmS1bNzKpDXJhT (#499) * Fix(connector): Return an error when storage cannot be read instead of panicking (#501) * Standalone: forward underlying rocksdb crate features (#502) * Feat(tests): Multisender benchmark (#503) * Feat(test): Reproduce D98vwmi44hAYs8KtX5aLne1zEkj3MUss42e5SkG2a4SC (#504) * Standalone engine storage saves the AccountId of the associated engine deployed on chain (#510) * Fix(precompiles): Fix secp256k1 run not returning empty slice on an incorrect V byte (#513) * Self-contained wasm contract for testing 5bEgfRQ (#514) * Update gas estimation code to use new data from NEAR protocol v53 (#517) * Fix: Legacy transactions must be allowed (#520) * Chore(precompiles): Include blake2 compression only (#528) * Build(deps): Upgrade `libsecp256k1` version 0.3.5 => 0.7.0 (#515) * Bump regex from 1.5.4 to 1.5.6 (#526) * Bump regex from 1.5.4 to 1.5.6 in /etc/ft-receiver (#525) * Bump zeroize_derive from 1.1.0 to 1.3.2 (#523) * Bump crossbeam-deque from 0.8.0 to 0.8.1 (#521) * Bump crossbeam-utils from 0.8.4 to 0.8.8 (#524) * Bump cross-fetch from 2.2.3 to 2.2.6 in /etc/eth-contracts (#508) * Bump simple-get from 2.8.1 to 2.8.2 in /etc/eth-contracts (#507) * Bump follow-redirects from 1.14.0 to 1.15.1 in /etc/eth-contracts (#529) * Bump shelljs from 0.8.4 to 0.8.5 in /etc/eth-contracts * Fix(ecrecover): Set malleability flag to `0` for ecrecover. (#474) Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Roman Hodulák <roman.hodulak@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Release 2.6.1. (#537) * Fix: Don't allow fee stealing. * Fix: Don't allow bridge receipt forging. * Fix(engine): Correctly account for changes in total supply of ETH on Aurora (#536) Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>

@mooori

Feat(tracing): Implement callTracer (#538) Add docker as a prerequisites (#542) This was found by @mooori while running tests for first time. Update dependencies (#541) Update etc/self-contained-5bEgfRQ Decrease gas usage for some tests Merge: 2.6.1 into `develop` from `master` (#546) * Feat(standalone): Add debug tracing of remaining gas values (#391) * Balance type refactoring (#386) * Remove standalone binary (#403) * Eth Address cleanup (#387) * Fix(dep) Pass std feature on to rjson library (#402) * Feat(benchmarks): update gas bounds after wasm cost reduction (#406) * Feat(tests): Mock touching trie nodes (#408) * Fix: Only allow owner to call deploy_upgrade (#410) * Feat(tests): Uniswap multi-hop swap benchmark (#415) * Fix(engine): Return revert error message during contract deploy (#424) * Move engine transactions module to engine-transactions crate (#418) * Avoid using wasmer directly (#420) * Fix compilation after #418 merge * Use default git attributes for Cargo.lock (#421) * Switch to rebranded blake2 (#422) * Remove unused unused (#423) * Chore: make aurora compatible with latest nightlies (#425) * Chore: upgrade to the recent nightly (#426) * chore: upgrade to the latest nearcore version (#427) * chore: move to 2021 edition (#428) * Benchmark contract performing only pure arithmetic and memory operations (#429) * Fix(engine): Require chain_id (#432) * chore: make sure aurora is using the latest cost config (#435) * Fix(test): make uniswap benchmarks reproducible (#437) * Fix(test): lower gas limit on OOG test; this is needed because the solidity compiler got more efficient, not because of a regression in EVM gas metering correctness * Fix(engine): Cache generation values to avoid repeated state reads (#438) * Fix(engine): Optimize is_account_empty (#439) * Fix(test): update uniswap wasm fraction; this is needed because optimizations from #438 and #439 together lowered the fraction of gas spent on IO * Fix(engine): Upgrade to latest SputnikVM (#445) * Fix(engine): Simple cache to stop consecutive duplicate reads (#446) * Version update and change log Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.5.0. (#460) * Engine: Upgrade to latest SputnikVM changes (#455) * Engine: further caching optimizations (#456) * Use EthTransactionKind reference to serialize into bytes (#457) * Test: Reproduce GdASJ3KESs8VegpFECTveCwLQp8fxw8yvsauNEmGb6pZ gas failure (#454) * Fix typo: promise_create (#452) * Fix(Engine): Transactions to the zero address are not the same as transactions with empty to field (#458) Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.5.1. (#470) * Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462) * Implement a NEAR native version of the Solidity pure arithmetic benchmark to compare EVM execution cost with direct wasm cost (#463) * Fix features related to panic_info_message (#466) * Fix(standalone): set predecessor_account_id appropriately when executing promise callbacks (#467) * Fix(engine): fix bug in checking if an address exists (#469) * Version update * Update unreleased link Co-authored-by: Joshua J. Bouw <joshua.j.bouw@aurora.dev> Release 2.5.2. (#475) * Revert "Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462)" Release 2.5.3. (#527) * Fix(precompile): ExitToNear ExitToEthereum vulnerability patch Fix vulnerability Include exploit contract * Release 2.5.3 notes * Update solidity version Co-authored-by: Michael Birch <michael.birch@aurora.dev> Release 2.6.0. (#494) * Feat(Engine): Precompiles for predecessor_account_id and current_account_id (#462) * Fix(precompiles): Allow native precompiles to work in the standalone engine (#473) * Standalone engine improvements (#478) * Fix(Engine): Predecessor id precompile works in view calls (#477) * Feat(standalone): Persist transaction data (#481) * Feat(Engine): Add custom precompile for NEAR prepaid_gas (#479) * Test: Reproduce 8ru7VEAEbyfZdbC1W2PYQv2cY3W92rbTToDEN4yTp8aZ gas failure (#485) * Feat(standalone): Function to get latest/earliest block (#482) * Engine optimization: cache all reads from NEAR state (#488) * Feat(standalone): Handle call to new method of Engine contract (#490) * Feat(engine-types): optional serde integration (#468) * Changed near-blake2 dependency (#484) * Feat(standalone): thread-safety and serde (#496) * Refactor repro tests to have less boilerplate (#497) * Add serde for TraceTransaction (#495) * Fix(standalone): include possible execution errors in the TransactionIncludedOutcome result field (#500) * Reproduce transaction FRcorNvFojoxBrdiVMTy9gRD3H8EYXXKau4feevMZmFV (#498) * Reproduce transaction 5bEgfRQ5TSJfN9XCqYkMr9cgBLToM7JmS1bNzKpDXJhT (#499) * Fix(connector): Return an error when storage cannot be read instead of panicking (#501) * Standalone: forward underlying rocksdb crate features (#502) * Feat(tests): Multisender benchmark (#503) * Feat(test): Reproduce D98vwmi44hAYs8KtX5aLne1zEkj3MUss42e5SkG2a4SC (#504) * Standalone engine storage saves the AccountId of the associated engine deployed on chain (#510) * Fix(precompiles): Fix secp256k1 run not returning empty slice on an incorrect V byte (#513) * Self-contained wasm contract for testing 5bEgfRQ (#514) * Update gas estimation code to use new data from NEAR protocol v53 (#517) * Fix: Legacy transactions must be allowed (#520) * Chore(precompiles): Include blake2 compression only (#528) * Build(deps): Upgrade `libsecp256k1` version 0.3.5 => 0.7.0 (#515) * Bump regex from 1.5.4 to 1.5.6 (#526) * Bump regex from 1.5.4 to 1.5.6 in /etc/ft-receiver (#525) * Bump zeroize_derive from 1.1.0 to 1.3.2 (#523) * Bump crossbeam-deque from 0.8.0 to 0.8.1 (#521) * Bump crossbeam-utils from 0.8.4 to 0.8.8 (#524) * Bump cross-fetch from 2.2.3 to 2.2.6 in /etc/eth-contracts (#508) * Bump simple-get from 2.8.1 to 2.8.2 in /etc/eth-contracts (#507) * Bump follow-redirects from 1.14.0 to 1.15.1 in /etc/eth-contracts (#529) * Bump shelljs from 0.8.4 to 0.8.5 in /etc/eth-contracts * Fix(ecrecover): Set malleability flag to `0` for ecrecover. (#474) Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Roman Hodulák <roman.hodulak@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Release 2.6.1. (#537) * Fix: Don't allow fee stealing. * Fix: Don't allow bridge receipt forging. * Fix(engine): Correctly account for changes in total supply of ETH on Aurora (#536) Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Chore: Update js dependencies (#543) # Update JS dependencies A number of the JS dependencies were out of date and require to be updated. While a number of these were used almost exclusively for testing, the EVM ERC 20 contract is obviously used in production. Over the last year, we had carefully monitored to ensure that we have not been allowing security-related vulnerabilities into our production contracts. However updating these contracts is a good thing to do, and should be actively updated going forward as we do see slight performance gains in doing so. As a small bonus, this also introduces a force of updating the docker image used to compile some of the test / benchmark contracts. ## Related Issues There are no known related issues. ## Risk Analysis The EvmErc20 and EvmErc20V2 contracts have been recompiled due to the nature of these changes as the compiler has been updated. However, this is expected and intended. ## Testing None are required. Constant error messages (#535) * Added errors module and changed json errors * Set engine module errors as consts * Set connector module errors as consts * deposit_event const errors * extend const errors msgs chore: Cargo make integration (#378) Make files can be a bit messy and hard to read through the file. Luckily, a rust alternative exists which is quite clean and accomplishes the same goals in a Rust-friendly manner. What this accomplishes is a replace of `make` with `cargo make`. Why this is important is because we are able to get a cleaner make file that can have even better control with the use of profiles. That would make it quite difficult to run the run deployments on the wrong binaries as it'll correctly read the appropriate ENV file. On top of this, I had reworked the Github action workflows and I am getting no failures now. Which is good, less time spent with kickstarting it to work again. This also includes a monthly "sweep" to keep our footprint smaller. In the future, this can be improved by dropping `default_to_workspace = false` and adding a Makefile.toml to every single crate in our workspace. Do note, for whatever reason there was an efficiency being made on the `profile_erc20_get_balance()` test with this compilation which doesn't make itself immediately obvious. I have tried to figure out why this is but can not come up with a reason. I request reviewers to please try to notice why this is. This is low priority, and I have only been working on this while debugging precompiles. Chore: PR template (#548)  ## Description This adds a PR template to ensure that PRs are of the highest quality by providing guidelines and a helpful checklist. ## How should this be reviewed Ensure that everything that could be said has been said in this template. Do comment below if we should add any more particulars. ## Additional information This is based on a number of other templates that other projects have adopted (mainly Rust projects) but also heavily modified and have included particulars to the project itself. Chore: Delete binaries (#553) Chore(engine): Update to latest version of SputnikVM (#565) Chore(CI): Update checkout to v3 (#566) Chore: Disallow as_conversions (#561) Fix feature gated import in hash precompile Change missed featured `into` to `try_into` birchmd fixes Cleaner usize conversion error Fix missing vec in hash Fix tests Fix V check Fix testnet env EVM account Change hex feature from alloc to std Improve u64 to u8 conversion in JSON Cargo fmt Chore: Update Rust crypto libraries (#568) Revert ripemd160, as the lib is deprecated Fix(engine-transactions): Prevent panic on empty input (#573) Feat(engine): Get promise results precompile (#575) Fix(engine): Return correct value for get_bridge_prover function (#581) Refactor(Tests): Move test contracts to test etc folder (#577) Co-authored-by: Michael Birch <michael.birch@aurora.dev> Chore: Cleanup dead dependencies (#571) Chore(Precompiles): Ripemd160 lib deprecated (#570) Feat(precompiles): Use near host functions for alt_bn128 when compiling wasm artifact (#540) Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Feat(engine): Cross contract calls (#560) Chore(eth-contracts): Update openzeppelin to 4.7.3 (#584) Fix: Make binaries on push (#585) 2.7.0 release prep

joshuajbouw changed the title ~~Eth Addrass cleanup~~ Eth Address cleanup Dec 8, 2021

mrLSD closed this Dec 14, 2021

mrLSD force-pushed the feat/eth-addrass-cleanup branch from 8b632a0 to cada6e0 Compare December 14, 2021 16:24

Added address file

b2cb328

mrLSD reopened this Dec 14, 2021

mrLSD changed the base branch from feat/balance to develop December 14, 2021 16:28

mrLSD self-assigned this Dec 14, 2021

mrLSD added the C-enhancement Category: New feature or request label Dec 14, 2021

mrLSD added 16 commits December 14, 2021 19:03

Changed basic Address dependency

94d7c7f

Changed Addess dependecies

f493404

Added AddressConst

c1204c8

Fix address types for engine

edc99ad

Removed EthAddress type

bdbcb45

Changed Address const methods

99194ec

Remove old Address type invokes

05f7986

Engine - Address changes

b98046d

Fix Connector, Engine types for Address

88bba7d

Changed tests

3186c30

Fix tests

fa23f14

Fix tests

175f406

Fix test

f2187af

Fix Address BorshDeserialize

2d9434e

Fix borsh tests

d3261b1

Fix bully

6729ea7

mrLSD marked this pull request as ready for review December 16, 2021 22:55

mrLSD requested a review from joshuajbouw as a code owner December 16, 2021 22:55

mrLSD requested a review from birchmd December 16, 2021 22:55

joshuajbouw suggested changes Dec 17, 2021

View reviewed changes

engine-types/src/lib.rs Outdated Show resolved Hide resolved

engine-types/src/parameters.rs Outdated Show resolved Hide resolved

engine/src/connector.rs Show resolved Hide resolved

Merge branch 'develop' of github.com:aurora-is-near/aurora-engine int…

d70dc41

…o feat/eth-addrass-cleanup

birchmd reviewed Dec 17, 2021

View reviewed changes

mrLSD and others added 6 commits December 20, 2021 17:54

Changed type for SignedTransaction1559. Added test_address_deocde

21b1a9c

Update engine/src/engine.rs

2c50149

Co-authored-by: Michael Birch <birchmd8@gmail.com>

Changed method from_array

617bfbe

Changed Address from_array

29b5ed0

Merge branch 'feat/eth-addrass-cleanup' of github.com:aurora-is-near/…

193b9c7

…aurora-engine into feat/eth-addrass-cleanup

Remove and Rename ADDRESS to Address::new

8fab0e6

mrLSD requested review from joshuajbouw and birchmd December 21, 2021 08:26

birchmd approved these changes Dec 22, 2021

View reviewed changes

engine-types/src/types/address.rs Outdated Show resolved Hide resolved

engine-types/src/types/address.rs Outdated Show resolved Hide resolved

engine/src/engine.rs Outdated Show resolved Hide resolved

mrLSD and others added 4 commits December 22, 2021 12:33

Update engine-types/src/types/address.rs

2dfde80

Co-authored-by: Michael Birch <birchmd8@gmail.com>

Update engine-types/src/types/address.rs

282d527

Co-authored-by: Michael Birch <birchmd8@gmail.com>

Update engine/src/engine.rs

7cf3a3c

Co-authored-by: Michael Birch <birchmd8@gmail.com>

Added decode reference

28f0bda

joshuajbouw approved these changes Dec 22, 2021

View reviewed changes

mrLSD merged commit c606252 into develop Dec 22, 2021

mrLSD deleted the feat/eth-addrass-cleanup branch December 22, 2021 17:04

birchmd pushed a commit that referenced this pull request Feb 16, 2022

Eth Address cleanup (#387)

0b124d6

birchmd mentioned this pull request Feb 16, 2022

Release 2.4.0 #449

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eth Address cleanup #387

Eth Address cleanup #387

mrLSD commented Dec 8, 2021

joshuajbouw left a comment

birchmd left a comment

birchmd left a comment

joshuajbouw left a comment

Eth Address cleanup #387

Eth Address cleanup #387

Conversation

mrLSD commented Dec 8, 2021

joshuajbouw left a comment

Choose a reason for hiding this comment

birchmd left a comment

Choose a reason for hiding this comment

birchmd left a comment

Choose a reason for hiding this comment

joshuajbouw left a comment

Choose a reason for hiding this comment